Overwrite only some settings in the security context when apparmor is enabled #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled It should overwrite only some settings in the security context when apparmor is enabled in order to keep the local seccomp profile in the security context. Change-Id: Ib48b8c4a63b773086ccef9c84538518829583adb Signed-off-by: Cosmin Cojocar <[email protected]>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
ccojocar
requested review from
saschagrunert
and removed request for
JAORMX and
Vincent056
saschagrunert
approved these changes
Dec 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It seems that the daemon container runs without the local seccomp profile in the security
context because is overwritten by the apparmor config.
It should overwrite only some settings in the security context when apparmor is enabled
in order to keep the local seccomp profile in the security context.
Which issue(s) this PR fixes:
Does this PR have test?
Yes
Special notes for your reviewer:
Does this PR introduce a user-facing change?